Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

Add announcement #6

Merged
merged 5 commits into from Aug 16, 2017
Merged

Add announcement #6

merged 5 commits into from Aug 16, 2017

Conversation

jprupp
Copy link
Contributor

@jprupp jprupp commented Aug 8, 2017

No description provided.


- Maximum block size doubles from 1,000,000 to 2,000,000.
- Sig-ops per block doubles from 20,000 to 40,000.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe DNS seeds should be mentioned here as well?


- BTC1: https://github.com/btc1/bitcoin
- Bitcoin Unlimited: https://www.bitcoinunlimited.info/

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitcoin classic is also compatible and i think we can expect a patch soon-ish from @zander that enforces a >1MB block

@jgarzik
Copy link
Contributor

jgarzik commented Aug 10, 2017

ACK so far - pinging some folks for wider comment

Will merge in a few days, pending additional comments

@vcorem
Copy link

vcorem commented Aug 10, 2017

Ack

1 similar comment
@magmahindenburg
Copy link

Ack


During the month of November 2017, approximately 90 days after the activation of Segregated Witnesses in the Bitcoin blockchain, a block between 1MB and 2MB in size will be generated by Bitcoin miners in a move to increase network capacity. At this point it is expected that more than 90% of the computational capacity that secures the Bitcoin network will carry on mining on top of this large block.

The upgrade to 2MB blocks has been agreed first during the [Bitcoin Roundtable Consensus in Hong-Kong](https://medium.com/@bitcoinroundtable/bitcoin-roundtable-consensus-266d475a61ff) on February 2016, and then ratified by the [Bitcoin Scaling Agreement in New York](https://medium.com/@DCGco/bitcoin-scaling-agreement-at-consensus-2017-133521fe9a77) on May 2017. These agreements stipulate the activation of Segregated Witness support and an increase of the maximum block size from 1MB to 2MB.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use "compatible block size" rather than just "block size", to be clear we're talking about base block size.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does compatible mean in this context? Compatible to whom?


For regular clients:

- Maximum block size doubles from 1,000,000 to 2,000,000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"compatible block size"
(base block size is also fine with me)

- OB1: seed.ob1.io
- Blockchain: seed.blockchain.info
- Bloq: bitcoin.bloqseeds.net

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the "require a large block on forking point" rule? Clients without this could break away from 2x's consensus.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, assuming the hashrate does not follow 2X, but it is not absolutely necessary to add this rule to make clients compatible with the majority hashrate, which is the intention.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the majority hashrate ever switches back to mining the non-2x chain, users of software that your checklist considers ready would have the entire 2x history - potentially years of it - wiped out from their clients in a massive reorg. Just puff, and their coins are gone.

Can you guarantee to the users following your "Readiness Checklist" that the mining majority will never switch back? Is that a risk you're willing to take for them?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total hashrate in bitcoin doubles every few months. This is likely to continue. 90% hashrate now can be 40% in six months, even if none of the signatories reduce their hashrate.

## Incompatible Fully-Validating Node Software

- Bitcoin Core: https://github.com/bitcoin/bitcoin
- Bitcoin UASF: http://www.uasf.co/
Copy link

@shesek shesek Aug 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more incompatible rule-validating software that you forgot to mention:

  • libbitcoin
  • bcoin
  • btcd
  • knots
  • bitcore
  • haskoin
  • nbitcoin
  • pynode
  • toshi (now retired, but probably still has users?)

Has there been any efforts to reach out to them? Are you okay with leaving users of these implementations behind?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment I have decided to go for a shorter list of fully-validating nodes that I am sure are compatible or not, and likely to remain so for the foreseeable future, and are frequently used in the wild or otherwise highly relevant. Some of these libraries and clients that you mentioned may deserve their own separate sections in the document. Feel free to submit a pull request with an update to the document if you are sure about 2MB (8MB?)-readiness of each.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clarify that with separate sections I mean “libraries” or “wallets” or “lightweight nodes”.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that bcoin, btcd, nbitcoin and knots are full node software, not a library / lightweight wallet.


## Readiness Checklist

The November 2107 upgrade to 2MB blocks is a hard-fork, but necessary changes are trivial to perform. Some SPV clients are expected to work without any change at all. Most clients will need to tweak only two constants to remain compatible with the new larger blocks:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

November 2107 may be safer timing for this hard fork from the standpoint of users and developers concerned with network stability, but the New York Agreement wants to fork this year, so please change this text to show the aggressive timeline accurately as November 2017.


## Readiness Checklist

The November 2017 upgrade to 2MB blocks is a hard-fork, but necessary changes are trivial to perform. Some SPV clients are expected to work without any change at all. Most clients will need to tweak only two constants to remain compatible with the new larger blocks:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "necessary" here is misleading because it wrongly suggests that this hard fork is necessary.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be less misleading if it said "politically compulsory" instead.

@shesek
Copy link

shesek commented Aug 12, 2017

NACK. the readiness checklist is lacking and would put users in severe risks, and the implementation list misses over half of the known implementations.

@jgarzik jgarzik merged commit dc24844 into segwit2x:master Aug 16, 2017
@shesek
Copy link

shesek commented Aug 16, 2017

  1. Why is the readiness checklist is still lacking? Users of implementations without wipeout protection would be taking severe risks.

  2. Why is the implementation list still not listing the (many!) other implementations that are missing?

@jgarzik
Copy link
Contributor

jgarzik commented Aug 16, 2017

@shesek You are welcome to contribute and improve things!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants